Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support merging b/w categorical data #8332

Merged
merged 15 commits into from
May 27, 2021
Merged

[REVIEW] Add support merging b/w categorical data #8332

merged 15 commits into from
May 27, 2021

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented May 24, 2021 •
edited
Loading

Fixes: #8200
This PR adds support for merging b/w categorical data by implementing union_categoricals_dispatch in dask-cudf. This PR is dependent on dask upstream changes: dask/dask#7699

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer non-breaking Non-breaking change labels May 24, 2021
@galipremsagar galipremsagar self-assigned this May 24, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 24, 2021 17:52
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 24, 2021
@galipremsagar galipremsagar mentioned this pull request May 24, 2021
Merged
3 tasks
@galipremsagar galipremsagar added the 0 - Blocked Cannot progress due to external reasons label May 24, 2021
@galipremsagar galipremsagar added the feature request New feature or request label May 24, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 25, 2021 13:53
@galipremsagar galipremsagar removed the 0 - Blocked Cannot progress due to external reasons label May 25, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels May 25, 2021
VibhuJawa
VibhuJawa approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PREM. LGTM

@shwina
Copy link
Contributor

shwina commented May 25, 2021

@gpucibot merge

@vyasr vyasr mentioned this pull request May 25, 2021
Merged
@kkraus14
Copy link
Collaborator

@gpucibot merge

@kkraus14
Copy link
Collaborator

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

Dear gpuCI, please show this PR some love ❤️

@kkraus14
Copy link
Collaborator

rerun tests

@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@cbbcba7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8332   +/-   ##
===============================================
  Coverage                ?   84.35%           
===============================================
  Files                   ?      109           
  Lines                   ?    20383           
  Branches                ?        0           
===============================================
  Hits                    ?    17195           
  Misses                  ?     3188           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbcba7...f17d9bd. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit f7ede6a into rapidsai:branch-21.06 May 27, 2021
@quasiben quasiben mentioned this pull request May 27, 2021
Closed
@RitikParmar RitikParmar mentioned this pull request Jul 15, 2022
Closed
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VibhuJawa VibhuJawa VibhuJawa approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@shwina shwina shwina approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support merge b/w categorical dask cudf dataframes
5 participants
@galipremsagar @shwina @kkraus14 @VibhuJawa @vyasr